feat: add Vitest testing framework, fix proxy auth stripping and 401 handling

- Set up Vitest with jsdom for client tests, node for server tests - Add tests for auth service, proxy handler, API client, and profiles store - Strip Authorization header in proxy to prevent web-ui token leaking to gateway - Distinguish local BFF vs proxied gateway 401s to avoid false logouts - Remove unused hero.png asset Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-16 20:24:09 +08:00
parent 26423984d1
commit 076a7c2a38
12 changed files with 707 additions and 21 deletions
@@ -0,0 +1,145 @@
+import { describe, it, expect, vi, beforeEach } from 'vitest'
+
+// Mock config
+vi.mock('../../packages/server/src/config', () => ({
+  config: { upstream: 'http://127.0.0.1:8642' },
+}))
+
+const mockFetch = vi.fn()
+vi.stubGlobal('fetch', mockFetch)
+
+import { proxy } from '../../packages/server/src/routes/hermes/proxy-handler'
+
+function createMockCtx(overrides: Record<string, any> = {}) {
+  let headersSent = false
+  const ctx: any = {
+    path: '/api/hermes/jobs',
+    method: 'GET',
+    headers: { host: 'localhost:8648', 'content-type': 'application/json' },
+    query: {},
+    search: '',
+    req: { method: 'GET' },
+    res: {
+      write: vi.fn(),
+      end: vi.fn(),
+      headersSent: false,
+      writableEnded: false,
+    },
+    request: { rawBody: undefined },
+    status: 200,
+    set: vi.fn(),
+    body: null,
+    ...overrides,
+  }
+  return ctx
+}
+
+describe('Proxy Handler', () => {
+  beforeEach(() => {
+    vi.clearAllMocks()
+  })
+
+  it('rewrites /api/hermes/v1/* to /v1/*', async () => {
+    mockFetch.mockResolvedValue({
+      status: 200,
+      headers: new Headers({ 'content-type': 'application/json' }),
+      body: null,
+      json: () => Promise.resolve({ ok: true }),
+    })
+
+    const ctx = createMockCtx({ path: '/api/hermes/v1/runs', search: '' })
+    await proxy(ctx)
+
+    expect(mockFetch).toHaveBeenCalledOnce()
+    const url = mockFetch.mock.calls[0][0]
+    expect(url).toContain('/v1/runs')
+    expect(url).not.toContain('/api/hermes')
+  })
+
+  it('rewrites /api/hermes/* to /api/*', async () => {
+    mockFetch.mockResolvedValue({
+      status: 200,
+      headers: new Headers({ 'content-type': 'application/json' }),
+      body: null,
+      json: () => Promise.resolve({ ok: true }),
+    })
+
+    const ctx = createMockCtx({ path: '/api/hermes/jobs', search: '' })
+    await proxy(ctx)
+
+    const url = mockFetch.mock.calls[0][0]
+    expect(url).toContain('/api/jobs')
+    expect(url).not.toContain('/api/hermes')
+  })
+
+  it('strips authorization header', async () => {
+    mockFetch.mockResolvedValue({
+      status: 200,
+      headers: new Headers({ 'content-type': 'application/json' }),
+      body: null,
+      json: () => Promise.resolve({}),
+    })
+
+    const ctx = createMockCtx({
+      headers: { host: 'localhost:8648', authorization: 'Bearer web-ui-token' },
+    })
+    await proxy(ctx)
+
+    const [, options] = mockFetch.mock.calls[0]
+    expect(options.headers.authorization).toBeUndefined()
+  })
+
+  it('replaces host header with upstream host', async () => {
+    mockFetch.mockResolvedValue({
+      status: 200,
+      headers: new Headers({ 'content-type': 'application/json' }),
+      body: null,
+      json: () => Promise.resolve({}),
+    })
+
+    const ctx = createMockCtx()
+    await proxy(ctx)
+
+    const [, options] = mockFetch.mock.calls[0]
+    expect(options.headers.host).toBe('127.0.0.1:8642')
+  })
+
+  it('forwards query string', async () => {
+    mockFetch.mockResolvedValue({
+      status: 200,
+      headers: new Headers({ 'content-type': 'text/event-stream' }),
+      body: null,
+      json: () => Promise.resolve({}),
+    })
+
+    const ctx = createMockCtx({ search: '?include_disabled=true' })
+    await proxy(ctx)
+
+    const url = mockFetch.mock.calls[0][0]
+    expect(url).toContain('?include_disabled=true')
+  })
+
+  it('returns 502 on connection failure', async () => {
+    mockFetch.mockRejectedValue(new Error('ECONNREFUSED'))
+
+    const ctx = createMockCtx()
+    await proxy(ctx)
+
+    expect(ctx.status).toBe(502)
+    expect(ctx.body).toEqual({ error: { message: 'Proxy error: ECONNREFUSED' } })
+  })
+
+  it('passes through non-200 status codes', async () => {
+    mockFetch.mockResolvedValue({
+      status: 404,
+      headers: new Headers({ 'content-type': 'application/json' }),
+      body: null,
+      json: () => Promise.resolve({ error: 'Not found' }),
+    })
+
+    const ctx = createMockCtx()
+    await proxy(ctx)
+
+    expect(ctx.status).toBe(404)
+  })
+})