feat(chat): add direct Live badge and harden Live monitor backend (#138)

* feat(chat): add direct live badge to session rows * fix(live): use session DB for conversations monitor * docs: add chat vs live monitor direction plan * fix(search): avoid numeric session search 500 without FTS table
2026-04-23 04:49:00 +02:00
parent 32dc084b66
commit 5f40ae6258
12 changed files with 1435 additions and 24 deletions
@@ -0,0 +1,107 @@
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+const listConversationSummariesFromDbMock = vi.fn()
+const getConversationDetailFromDbMock = vi.fn()
+const listConversationSummariesMock = vi.fn()
+const getConversationDetailMock = vi.fn()
+const loggerWarnMock = vi.fn()
+
+vi.mock('../../packages/server/src/db/hermes/conversations-db', () => ({
+  listConversationSummariesFromDb: listConversationSummariesFromDbMock,
+  getConversationDetailFromDb: getConversationDetailFromDbMock,
+}))
+
+vi.mock('../../packages/server/src/services/hermes/conversations', () => ({
+  listConversationSummaries: listConversationSummariesMock,
+  getConversationDetail: getConversationDetailMock,
+}))
+
+vi.mock('../../packages/server/src/services/logger', () => ({
+  logger: {
+    warn: loggerWarnMock,
+    error: vi.fn(),
+  },
+}))
+
+vi.mock('../../packages/server/src/services/hermes/hermes-cli', () => ({
+  listSessions: vi.fn(),
+  getSession: vi.fn(),
+  deleteSession: vi.fn(),
+  renameSession: vi.fn(),
+}))
+
+vi.mock('../../packages/server/src/db/hermes/sessions-db', () => ({
+  listSessionSummaries: vi.fn(),
+  searchSessionSummaries: vi.fn(),
+}))
+
+vi.mock('../../packages/server/src/db/hermes/usage-store', () => ({
+  deleteUsage: vi.fn(),
+  getUsage: vi.fn(),
+  getUsageBatch: vi.fn(),
+}))
+
+vi.mock('../../packages/server/src/services/hermes/model-context', () => ({
+  getModelContextLength: vi.fn(),
+}))
+
+describe('session conversations controller', () => {
+  beforeEach(() => {
+    vi.resetModules()
+    listConversationSummariesFromDbMock.mockReset()
+    getConversationDetailFromDbMock.mockReset()
+    listConversationSummariesMock.mockReset()
+    getConversationDetailMock.mockReset()
+    loggerWarnMock.mockReset()
+  })
+
+  it('prefers the DB-backed conversations summary path', async () => {
+    listConversationSummariesFromDbMock.mockResolvedValue([{ id: 'db-conversation' }])
+
+    const mod = await import('../../packages/server/src/controllers/hermes/sessions')
+    const ctx: any = { query: { humanOnly: 'true', limit: '5' }, body: null }
+    await mod.listConversations(ctx)
+
+    expect(listConversationSummariesFromDbMock).toHaveBeenCalledWith({ source: undefined, humanOnly: true, limit: 5 })
+    expect(listConversationSummariesMock).not.toHaveBeenCalled()
+    expect(ctx.body).toEqual({ sessions: [{ id: 'db-conversation' }] })
+  })
+
+  it('falls back to the CLI-export conversations summary path when the DB query fails', async () => {
+    listConversationSummariesFromDbMock.mockRejectedValue(new Error('db unavailable'))
+    listConversationSummariesMock.mockResolvedValue([{ id: 'fallback-conversation' }])
+
+    const mod = await import('../../packages/server/src/controllers/hermes/sessions')
+    const ctx: any = { query: { humanOnly: 'false' }, body: null }
+    await mod.listConversations(ctx)
+
+    expect(loggerWarnMock).toHaveBeenCalled()
+    expect(listConversationSummariesMock).toHaveBeenCalledWith({ source: undefined, humanOnly: false, limit: undefined })
+    expect(ctx.body).toEqual({ sessions: [{ id: 'fallback-conversation' }] })
+  })
+
+  it('prefers the DB-backed conversation detail path', async () => {
+    getConversationDetailFromDbMock.mockResolvedValue({ session_id: 'root', messages: [], visible_count: 0, thread_session_count: 1 })
+
+    const mod = await import('../../packages/server/src/controllers/hermes/sessions')
+    const ctx: any = { params: { id: 'root' }, query: { humanOnly: 'true' }, body: null }
+    await mod.getConversationMessages(ctx)
+
+    expect(getConversationDetailFromDbMock).toHaveBeenCalledWith('root', { source: undefined, humanOnly: true })
+    expect(getConversationDetailMock).not.toHaveBeenCalled()
+    expect(ctx.body).toEqual({ session_id: 'root', messages: [], visible_count: 0, thread_session_count: 1 })
+  })
+
+  it('falls back to the CLI-export conversation detail path when the DB query throws', async () => {
+    getConversationDetailFromDbMock.mockRejectedValue(new Error('db unavailable'))
+    getConversationDetailMock.mockResolvedValue({ session_id: 'root', messages: [{ id: 1 }], visible_count: 1, thread_session_count: 1 })
+
+    const mod = await import('../../packages/server/src/controllers/hermes/sessions')
+    const ctx: any = { params: { id: 'root' }, query: { humanOnly: 'false' }, body: null }
+    await mod.getConversationMessages(ctx)
+
+    expect(loggerWarnMock).toHaveBeenCalled()
+    expect(getConversationDetailMock).toHaveBeenCalledWith('root', { source: undefined, humanOnly: false })
+    expect(ctx.body).toEqual({ session_id: 'root', messages: [{ id: 1 }], visible_count: 1, thread_session_count: 1 })
+  })
+})