[codex] increase login lock threshold (#984)

* increase login ip lock threshold

* show login lock recovery commands
This commit is contained in:
ekko
2026-05-24 22:36:21 +08:00
committed by GitHub
parent 4176923bac
commit 61b41512d4
13 changed files with 134 additions and 1 deletions
+21
View File
@@ -73,4 +73,25 @@ describe('LoginView password login', () => {
expect(mockSetApiKey).not.toHaveBeenCalled()
expect(mockReplace).not.toHaveBeenCalled()
})
it('shows the reset command hint when the login IP is locked', async () => {
const err: any = new Error('Too many login attempts')
err.status = 429
mockLoginWithPassword.mockRejectedValue(err)
const wrapper = mount(LoginView)
const inputs = wrapper.findAll('input.login-input')
await inputs[0].setValue('admin')
await inputs[1].setValue('123456')
await wrapper.find('form.login-form').trigger('submit')
expect(wrapper.find('.login-error').text()).toBe('login.tooManyAttempts')
expect(wrapper.find('.login-lock-hint').text()).toContain('login.lockResetHint')
expect(wrapper.find('.login-lock-hint').text()).toContain('login.defaultLoginResetHint')
const commands = wrapper.findAll('.login-lock-hint code').map(command => command.text())
expect(commands).toEqual([
'hermes-web-ui clear-login-locks --restart',
'hermes-web-ui reset-default-login',
])
})
})
+66
View File
@@ -0,0 +1,66 @@
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
async function loadLimiter() {
vi.resetModules()
vi.doMock('fs/promises', () => ({
readFile: vi.fn().mockRejectedValue(new Error('ENOENT')),
writeFile: vi.fn(),
mkdir: vi.fn(),
}))
vi.doMock('fs', () => ({ writeFileSync: vi.fn() }))
vi.doMock('../../packages/server/src/config', () => ({
config: { appHome: '/tmp/hermes-web-ui-test' },
}))
return import('../../packages/server/src/services/login-limiter')
}
describe('login limiter', () => {
beforeEach(() => {
vi.useFakeTimers()
vi.setSystemTime(new Date('2026-05-24T00:00:00Z'))
})
afterEach(() => {
vi.useRealTimers()
vi.doUnmock('fs/promises')
vi.doUnmock('fs')
vi.doUnmock('../../packages/server/src/config')
vi.resetModules()
})
it('locks password login on the tenth failed attempt from the same IP', async () => {
const limiter = await loadLimiter()
const ip = '192.0.2.10'
for (let i = 0; i < 9; i++) {
expect(limiter.checkPassword(ip)).toEqual({ allowed: true })
limiter.recordPasswordFailure(ip)
}
expect(limiter.checkPassword(ip)).toEqual({ allowed: true })
limiter.recordPasswordFailure(ip)
expect(limiter.checkPassword(ip)).toEqual({ allowed: false, status: 429 })
expect(limiter.getLockedIps()).toEqual([
expect.objectContaining({ ip, type: 'password', failures: 10 }),
])
})
it('locks token auth on the tenth failed attempt from the same IP', async () => {
const limiter = await loadLimiter()
const ip = '192.0.2.20'
for (let i = 0; i < 9; i++) {
expect(limiter.checkToken(ip)).toEqual({ allowed: true })
limiter.recordTokenFailure(ip)
}
expect(limiter.checkToken(ip)).toEqual({ allowed: true })
limiter.recordTokenFailure(ip)
expect(limiter.checkToken(ip)).toEqual({ allowed: false, status: 429 })
expect(limiter.getLockedIps()).toEqual([
expect.objectContaining({ ip, type: 'token', failures: 10 }),
])
})
})