fix clarify replay and compression timeout (#1044)

This commit is contained in:
ekko
2026-05-26 19:15:22 +08:00
committed by GitHub
parent e926a8e2fb
commit 82680f5c0b
7 changed files with 104 additions and 7 deletions
@@ -406,7 +406,7 @@ class RoutedWorker:
self.requests = []
self.stopped = False
def request(self, req):
def request(self, req, timeout=None):
self.requests.append(req)
action = req.get("action")
if action == "chat":
@@ -634,6 +634,37 @@ assert not thread.is_alive(), blocking_conn.response
blocked_resp = json.loads(blocking_conn.response.decode("utf-8"))
assert blocked_resp["ok"] is True, blocked_resp
assert blocked_resp["blocked"] is True, blocked_resp
`)
})
it('extends profile worker request timeout from wait requests', () => {
runPython(String.raw`
${harness}
broker = bridge.BridgeBroker("ipc:///tmp/unused.sock")
assert broker._worker_request_timeout({"action": "chat"}) == bridge.WorkerProcess.REQUEST_TIMEOUT_SECONDS
assert broker._worker_request_timeout({"action": "chat", "timeout": 60}) == bridge.WorkerProcess.REQUEST_TIMEOUT_SECONDS
assert broker._worker_request_timeout({"action": "chat", "timeout": 300}) == 310
captured = {}
worker = bridge.WorkerProcess("default", "default", "ipc:///tmp/worker.sock", None, None)
worker.start = lambda: None
original_send = bridge._send_bridge_request
try:
def fake_send(endpoint, req, timeout):
captured["endpoint"] = endpoint
captured["req"] = req
captured["timeout"] = timeout
return {"ok": True}
bridge._send_bridge_request = fake_send
response = worker.request({"action": "chat"}, 310)
finally:
bridge._send_bridge_request = original_send
assert response["ok"] is True, response
assert captured["endpoint"] == "ipc:///tmp/worker.sock", captured
assert captured["req"] == {"action": "chat"}, captured
assert captured["timeout"] == 310, captured
`)
})
})
@@ -90,6 +90,48 @@ describe('ChatRunSocket clarify responses', () => {
})
})
it('does not replay answered clarify prompts when the session resumes', async () => {
bridgeMock.clarifyRespond.mockResolvedValue({ ok: true, resolved: true })
const { ChatRunSocket } = await import('../../packages/server/src/services/hermes/run-chat')
const { handlers, io, socket } = createSocketHarness()
const server = new ChatRunSocket(io as any)
const toolEvent = {
event: 'tool.started',
data: { event: 'tool.started', tool_call_id: 'tool-1' },
}
;(server as any).sessionMap.set('session-1', {
messages: [],
isWorking: true,
events: [
{
event: 'clarify.requested',
data: {
event: 'clarify.requested',
clarify_id: 'clarify-1',
question: 'Pick one',
},
},
toolEvent,
],
queue: [],
})
;(server as any).onConnection(socket)
await handlers.get('clarify.respond')?.({
session_id: 'session-1',
clarify_id: 'clarify-1',
response: 'Use option A',
})
await handlers.get('resume')?.({ session_id: 'session-1' })
expect((server as any).sessionMap.get('session-1').events).toEqual([toolEvent])
expect(socket.emit).toHaveBeenCalledWith('resumed', expect.objectContaining({
session_id: 'session-1',
isWorking: true,
events: [toolEvent],
}))
})
it('emits an unresolved clarify result when the bridge rejects the response', async () => {
bridgeMock.clarifyRespond.mockRejectedValue(new Error('unknown clarify request'))
const { ChatRunSocket } = await import('../../packages/server/src/services/hermes/run-chat')