From b2a80808e3bdb493c52db5271e9e7b27243c7552 Mon Sep 17 00:00:00 2001 From: ekko <152005280+EKKOLearnAI@users.noreply.github.com> Date: Thu, 14 May 2026 10:34:10 +0800 Subject: [PATCH] fix: comment out pending session delete operations in group chat (#703) Co-authored-by: Claude Opus 4.7 --- .../server/src/controllers/hermes/profiles.ts | 15 ++++++++------- .../src/services/hermes/group-chat/index.ts | 16 +++++++++------- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/packages/server/src/controllers/hermes/profiles.ts b/packages/server/src/controllers/hermes/profiles.ts index a7cc21c..690b1bd 100644 --- a/packages/server/src/controllers/hermes/profiles.ts +++ b/packages/server/src/controllers/hermes/profiles.ts @@ -235,18 +235,19 @@ export async function switchProfile(ctx: any) { logger.error(err, 'Ensure config failed') } - const drainResult = await SessionDeleter.getInstance().drain(name) + // TODO: re-enable pending session delete drain after confirming safety + // const drainResult = await SessionDeleter.getInstance().drain(name) SessionDeleter.getInstance().switchProfile(name) - logger.info('[switchProfile] drain result for profile "%s": %d deleted, %d failed', name, drainResult.deleted.length, drainResult.failed.length) - if (drainResult.failed.length > 0) { - logger.warn({ profile: name, failed: drainResult.failed }, 'Failed to drain some pending session deletes after profile switch') - } + logger.info('[switchProfile] switched session deleter to profile "%s"', name) + // if (drainResult.failed.length > 0) { + // logger.warn({ profile: name, failed: drainResult.failed }, 'Failed to drain some pending session deletes after profile switch') + // } ctx.body = { success: true, message: output.trim(), - drained_session_deletes: drainResult.deleted.length, - failed_session_deletes: drainResult.failed.length, + // drained_session_deletes: drainResult.deleted.length, + // failed_session_deletes: drainResult.failed.length, } } catch (err: any) { ctx.status = 500 diff --git a/packages/server/src/services/hermes/group-chat/index.ts b/packages/server/src/services/hermes/group-chat/index.ts index 9407da7..8dab65d 100644 --- a/packages/server/src/services/hermes/group-chat/index.ts +++ b/packages/server/src/services/hermes/group-chat/index.ts @@ -448,13 +448,15 @@ export class GroupChatServer { const contextEngine = new ContextEngine({ messageFetcher: this.storage, sessionCleaner: async (sessionId: string) => { - try { - const profile = this.storage.getSessionProfile(sessionId) - const profileName = profile?.profile_name || 'default' - this.storage.enqueuePendingSessionDelete(sessionId, profileName) - } catch (err: any) { - logger.warn(`[GroupChat] failed to enqueue compression session delete ${sessionId}: ${err.message}`) - } + // TODO: re-enable session deletion after confirming it doesn't + // accidentally remove user-created sessions outside group chat. + // try { + // const profile = this.storage.getSessionProfile(sessionId) + // const profileName = profile?.profile_name || 'default' + // this.storage.enqueuePendingSessionDelete(sessionId, profileName) + // } catch (err: any) { + // logger.warn(`[GroupChat] failed to enqueue compression session delete ${sessionId}: ${err.message}`) + // } }, }) this.agentClients.setContextEngine(contextEngine)