[codex] add clarify support with response path tests (#972)

* feat: 新增 clarify(澄清/确认)交互支持

* test clarify response bridge path

---------

Co-authored-by: GoldenFish123321 <golden_fish@foxmail.com>
This commit is contained in:
ekko
2026-05-24 18:09:39 +08:00
committed by GitHub
parent a7f0a92fe6
commit e743c81ad3
17 changed files with 568 additions and 1 deletions
@@ -0,0 +1,20 @@
import { describe, expect, it, vi } from 'vitest'
describe('AgentBridgeClient clarify responses', () => {
it('sends clarify_respond requests to the bridge', async () => {
const { AgentBridgeClient } = await import('../../packages/server/src/services/hermes/agent-bridge/client')
const client = new AgentBridgeClient({ endpoint: 'tcp://127.0.0.1:1', connectRetryMs: 0, timeoutMs: 1 })
const request = vi.spyOn(client, 'request').mockResolvedValue({ ok: true, resolved: true })
await expect(client.clarifyRespond('clarify-1', 'Use the first option')).resolves.toEqual({
ok: true,
resolved: true,
})
expect(request).toHaveBeenCalledWith({
action: 'clarify_respond',
clarify_id: 'clarify-1',
response: 'Use the first option',
})
})
})
@@ -0,0 +1,120 @@
import { beforeEach, describe, expect, it, vi } from 'vitest'
const bridgeMock = vi.hoisted(() => ({
clarifyRespond: vi.fn(),
}))
vi.mock('../../packages/server/src/services/hermes/agent-bridge', () => ({
AgentBridgeClient: vi.fn(() => bridgeMock),
}))
vi.mock('../../packages/server/src/services/logger', () => ({
logger: {
info: vi.fn(),
warn: vi.fn(),
error: vi.fn(),
},
}))
vi.mock('../../packages/server/src/db/hermes/session-store', () => ({
getSession: vi.fn(() => null),
}))
vi.mock('../../packages/server/src/services/hermes/hermes-profile', () => ({
getActiveProfileName: vi.fn(() => 'default'),
getProfileDir: vi.fn(() => '/tmp/hermes-default'),
listProfileNamesFromDisk: vi.fn(() => ['default']),
}))
vi.mock('../../packages/server/src/middleware/user-auth', () => ({
authenticateUserToken: vi.fn(),
isAuthEnabled: vi.fn(async () => false),
}))
vi.mock('../../packages/server/src/db/hermes/users-store', () => ({
userCanAccessProfile: vi.fn(() => true),
}))
function createSocketHarness() {
const handlers = new Map<string, Function>()
const namespaceEmit = vi.fn()
const namespace = {
adapter: { rooms: new Map([['session:session-1', new Set(['socket-1'])]]) },
to: vi.fn(() => ({ emit: namespaceEmit })),
use: vi.fn(),
on: vi.fn(),
}
const io = {
of: vi.fn(() => namespace),
}
const socket = {
id: 'socket-1',
connected: true,
data: {},
handshake: { auth: {}, query: { profile: 'default' } },
on: vi.fn((event: string, handler: Function) => {
handlers.set(event, handler)
}),
join: vi.fn(),
emit: vi.fn(),
}
return { handlers, io, namespace, namespaceEmit, socket }
}
describe('ChatRunSocket clarify responses', () => {
beforeEach(() => {
vi.resetModules()
bridgeMock.clarifyRespond.mockReset()
})
it('forwards clarify.respond events to the bridge and emits clarify.resolved', async () => {
bridgeMock.clarifyRespond.mockResolvedValue({ ok: true, resolved: true })
const { ChatRunSocket } = await import('../../packages/server/src/services/hermes/run-chat')
const { handlers, io, namespace, namespaceEmit, socket } = createSocketHarness()
const server = new ChatRunSocket(io as any)
;(server as any).onConnection(socket)
await handlers.get('clarify.respond')?.({
session_id: 'session-1',
clarify_id: 'clarify-1',
response: 'Use option A',
})
expect(bridgeMock.clarifyRespond).toHaveBeenCalledWith('clarify-1', 'Use option A')
expect(namespace.to).toHaveBeenCalledWith('session:session-1')
expect(namespaceEmit).toHaveBeenCalledWith('clarify.resolved', {
event: 'clarify.resolved',
session_id: 'session-1',
clarify_id: 'clarify-1',
resolved: true,
})
})
it('emits an unresolved clarify result when the bridge rejects the response', async () => {
bridgeMock.clarifyRespond.mockRejectedValue(new Error('unknown clarify request'))
const { ChatRunSocket } = await import('../../packages/server/src/services/hermes/run-chat')
const { handlers, namespaceEmit, socket } = createSocketHarness()
const namespace = {
adapter: { rooms: new Map([['session:session-1', new Set(['socket-1'])]]) },
to: vi.fn(() => ({ emit: namespaceEmit })),
use: vi.fn(),
on: vi.fn(),
}
const server = new ChatRunSocket({ of: vi.fn(() => namespace) } as any)
;(server as any).onConnection(socket)
await handlers.get('clarify.respond')?.({
session_id: 'session-1',
clarify_id: 'clarify-1',
response: 'Use option B',
})
expect(namespaceEmit).toHaveBeenCalledWith('clarify.resolved', {
event: 'clarify.resolved',
session_id: 'session-1',
clarify_id: 'clarify-1',
resolved: false,
error: 'unknown clarify request',
})
})
})