fix: recover legacy session_usage migration (#345)

Quote SQL defaults when rebuilding legacy usage tables and recover rows left in session_usage_old by failed migrations.
2026-04-30 11:17:20 +02:00
parent cd14bb1963
commit e82674039c
2 changed files with 236 additions and 27 deletions
@@ -0,0 +1,119 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+
+function quoteIdentifier(identifier: string): string {
+  return `"${identifier.replace(/"/g, '""')}"`
+}
+
+function ensureTableForTest(db: any, tableName: string, schema: Record<string, string>): void {
+  const colDefs = Object.entries(schema)
+    .map(([col, def]) => `${quoteIdentifier(col)} ${def}`)
+    .join(', ')
+  db.exec(`CREATE TABLE IF NOT EXISTS ${quoteIdentifier(tableName)} (${colDefs})`)
+
+  const rows = db.prepare(`PRAGMA table_info(${quoteIdentifier(tableName)})`).all() as Array<{ name: string }>
+  const existingCols = new Set(rows.map(row => row.name))
+
+  for (const [col, def] of Object.entries(schema)) {
+    if (!existingCols.has(col)) {
+      db.exec(`ALTER TABLE ${quoteIdentifier(tableName)} ADD COLUMN ${quoteIdentifier(col)} ${def}`)
+    }
+  }
+}
+
+describe('Hermes schema migrations', () => {
+  let db: any = null
+
+  beforeEach(async () => {
+    vi.resetModules()
+    const { DatabaseSync } = await import('node:sqlite')
+    db = new DatabaseSync(':memory:')
+    vi.doMock('../../packages/server/src/db/index', () => ({
+      getDb: () => db,
+      ensureTable: (tableName: string, schema: Record<string, string>) => ensureTableForTest(db, tableName, schema),
+    }))
+  })
+
+  afterEach(() => {
+    db?.close()
+    db = null
+    vi.doUnmock('../../packages/server/src/db/index')
+    vi.resetModules()
+  })
+
+  it('migrates legacy session_usage rows with SQL-safe defaults', async () => {
+    const updatedAt = Date.UTC(2026, 3, 29)
+    db.exec(`CREATE TABLE "session_usage" (
+      "session_id" TEXT PRIMARY KEY,
+      "input_tokens" INTEGER NOT NULL DEFAULT 0,
+      "output_tokens" INTEGER NOT NULL DEFAULT 0,
+      "updated_at" INTEGER NOT NULL
+    )`)
+    db.prepare(
+      `INSERT INTO "session_usage" (session_id, input_tokens, output_tokens, updated_at) VALUES (?, ?, ?, ?)`,
+    ).run('legacy-session', 123, 45, updatedAt)
+
+    const { initAllHermesTables } = await import('../../packages/server/src/db/hermes/schemas')
+
+    expect(() => initAllHermesTables()).not.toThrow()
+
+    const row = db.prepare(
+      `SELECT session_id, input_tokens, output_tokens, cache_read_tokens, cache_write_tokens,
+              reasoning_tokens, model, profile, created_at
+       FROM "session_usage"`,
+    ).get() as any
+    expect(row).toMatchObject({
+      session_id: 'legacy-session',
+      input_tokens: 123,
+      output_tokens: 45,
+      cache_read_tokens: 0,
+      cache_write_tokens: 0,
+      reasoning_tokens: 0,
+      model: '',
+      profile: 'default',
+      created_at: updatedAt,
+    })
+    expect(db.prepare(`SELECT name FROM sqlite_master WHERE type='table' AND name='session_usage_old'`).get()).toBeUndefined()
+  })
+
+  it('recovers rows left in session_usage_old by a failed previous migration', async () => {
+    const updatedAt = Date.UTC(2026, 3, 30)
+    db.exec(`CREATE TABLE "session_usage" (
+      "id" INTEGER PRIMARY KEY AUTOINCREMENT,
+      "session_id" TEXT NOT NULL,
+      "input_tokens" INTEGER NOT NULL DEFAULT 0,
+      "output_tokens" INTEGER NOT NULL DEFAULT 0,
+      "cache_read_tokens" INTEGER NOT NULL DEFAULT 0,
+      "cache_write_tokens" INTEGER NOT NULL DEFAULT 0,
+      "reasoning_tokens" INTEGER NOT NULL DEFAULT 0,
+      "model" TEXT NOT NULL DEFAULT '',
+      "profile" TEXT NOT NULL DEFAULT 'default',
+      "created_at" INTEGER NOT NULL
+    )`)
+    db.exec(`CREATE TABLE "session_usage_old" (
+      "session_id" TEXT PRIMARY KEY,
+      "input_tokens" INTEGER NOT NULL DEFAULT 0,
+      "output_tokens" INTEGER NOT NULL DEFAULT 0,
+      "updated_at" INTEGER NOT NULL
+    )`)
+    db.prepare(
+      `INSERT INTO "session_usage_old" (session_id, input_tokens, output_tokens, updated_at) VALUES (?, ?, ?, ?)`,
+    ).run('stranded-session', 200, 80, updatedAt)
+
+    const { initAllHermesTables } = await import('../../packages/server/src/db/hermes/schemas')
+
+    expect(() => initAllHermesTables()).not.toThrow()
+
+    const row = db.prepare(
+      `SELECT session_id, input_tokens, output_tokens, model, profile, created_at FROM "session_usage"`,
+    ).get() as any
+    expect(row).toMatchObject({
+      session_id: 'stranded-session',
+      input_tokens: 200,
+      output_tokens: 80,
+      model: '',
+      profile: 'default',
+      created_at: updatedAt,
+    })
+    expect(db.prepare(`SELECT name FROM sqlite_master WHERE type='table' AND name='session_usage_old'`).get()).toBeUndefined()
+  })
+})