fix node npm detection (#1163)

2026-05-30 20:19:01 +08:00
parent dcbf601e35
commit fc35c74eb3
18 changed files with 406 additions and 53 deletions
@@ -307,6 +307,23 @@ function currentLaunchRequest() {
  }
 }

+function codingAgentMessage(code?: string, fallback?: string, fallbackKey = 'codingAgents.installFailed'): string {
+  if (code === 'node_environment_missing') return t('codingAgents.nodeEnvironmentMissing')
+  return fallback || t(fallbackKey)
+}
+
+function parseErrorPayload(err: any): { message?: string; code?: string } | null {
+  const messageText = String(err?.message || '')
+  const jsonStart = messageText.indexOf('{')
+  if (jsonStart < 0) return null
+  try {
+    const parsed = JSON.parse(messageText.slice(jsonStart))
+    return parsed && typeof parsed === 'object' ? parsed : null
+  } catch {
+    return null
+  }
+}
+
 async function launchBuiltInTerminal() {
  if (!useGlobalLaunchConfig.value && (!launchProvider.value || !launchModel.value)) {
    message.error(t('codingAgents.selectProviderModel'))
@@ -352,10 +369,11 @@ async function handleInstall(id: CodingAgentId) {
    if (result.success) {
      message.success(t('codingAgents.installSuccess'))
    } else {
-      message.error(result.message || t('codingAgents.installFailed'))
+      message.error(codingAgentMessage(result.code, result.message, 'codingAgents.installFailed'))
    }
  } catch (err: any) {
-    message.error(err?.message || t('codingAgents.installFailed'))
+    const payload = parseErrorPayload(err)
+    message.error(codingAgentMessage(payload?.code, payload?.message || err?.message, 'codingAgents.installFailed'))
  } finally {
    installing.value[id] = false
  }
@@ -369,10 +387,11 @@ async function handleDelete(id: CodingAgentId) {
    if (result.success) {
      message.success(t('codingAgents.deleteSuccess'))
    } else {
-      message.error(result.message || t('codingAgents.deleteFailed'))
+      message.error(codingAgentMessage(result.code, result.message, 'codingAgents.deleteFailed'))
    }
  } catch (err: any) {
-    message.error(err?.message || t('codingAgents.deleteFailed'))
+    const payload = parseErrorPayload(err)
+    message.error(codingAgentMessage(payload?.code, payload?.message || err?.message, 'codingAgents.deleteFailed'))
  } finally {
    deleting.value[id] = false
  }
@@ -77,6 +77,9 @@ async function loadRecommendations() {
    const response = await fetch(recommendationsPath.value)
    if (!response.ok) throw new Error(`HTTP ${response.status}`)
    const text = await response.text()
+    if (/^\s*<!doctype html/i.test(text) || /^\s*<html[\s>]/i.test(text)) {
+      throw new Error('Skill recommendations file was not found')
+    }
    if (requestSeq === recommendationsRequestSeq) {
      recommendations.value = text
    }