WeKnora deployment source with the reviewed wiki identity, summary and recovery fixes

internal/application/service/knowledge_manual_test.go

@@ -0,0 +1,95 @@
+package service
+
+import (
+	"testing"
+)
+
+// TestSanitizeManualDownloadFilename covers the filename-sanitization logic used
+// by the manual-knowledge download path in GetKnowledgeFile.
+func TestSanitizeManualDownloadFilename(t *testing.T) {
+	tests := []struct {
+		name  string
+		title string
+		want  string
+	}{
+		{
+			name:  "normal title produces title.md",
+			title: "My Knowledge Article",
+			want:  "My Knowledge Article.md",
+		},
+		{
+			name:  "forward slash replaced with dash",
+			title: "path/to/file",
+			want:  "path-to-file.md",
+		},
+		{
+			name:  "backslash replaced with dash",
+			title: `windows\path`,
+			want:  "windows-path.md",
+		},
+		{
+			name:  "double-quote replaced with single-quote",
+			title: `say "hello"`,
+			want:  "say 'hello'.md",
+		},
+		{
+			name:  "newline stripped",
+			title: "line1\nline2",
+			want:  "line1line2.md",
+		},
+		{
+			name:  "carriage return stripped",
+			title: "line1\rline2",
+			want:  "line1line2.md",
+		},
+		{
+			name:  "combination of dangerous chars",
+			title: "att\nack\r/header\\ \"injection\"",
+			want:  "attack-header- 'injection'.md",
+		},
+		{
+			name:  "blank title falls back to untitled",
+			title: "",
+			want:  "untitled.md",
+		},
+		{
+			name:  "whitespace-only title falls back to untitled",
+			title: "   \t  ",
+			want:  "untitled.md",
+		},
+		{
+			name:  "title that sanitizes to only whitespace falls back to untitled",
+			title: "\n\r",
+			want:  "untitled.md",
+		},
+		{
+			name:  "semicolon and equals preserved (safe in quoted header value)",
+			title: "a=b; c=d",
+			want:  "a=b; c=d.md",
+		},
+		{
+			name:  "Chinese title preserved",
+			title: "知识库文章",
+			want:  "知识库文章.md",
+		},
+		{
+			name:  "tab character stripped",
+			title: "file\tname",
+			want:  "filename.md",
+		},
+		{
+			name:  "title already ending in .md not double-extended",
+			title: "guide.md",
+			want:  "guide.md",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := sanitizeManualDownloadFilename(tt.title)
+			if got != tt.want {
+				t.Errorf("sanitizeManualDownloadFilename(%q) = %q, want %q", tt.title, got, tt.want)
+			}
+		})
+	}
+}