package service import ( "strings" "testing" "github.com/Tencent/WeKnora/internal/types" "github.com/stretchr/testify/require" ) func TestWikiCitationDeclarationOptionalDetailsRetainsEvidenceRequirements(t *testing.T) { batch := splitChunksIntoCitationBatches([]*types.Chunk{ {ID: "first", Content: "Alpha requires condition X."}, {ID: "second", Content: "Alpha excludes condition Y.", ChunkIndex: 1}, })[0] original := citationBatchResult{Citations: map[string][]string{"concept/alpha": {"first", "second"}}} missing := map[string][]string{"concept/alpha": {"c000", "c001"}} raw := `{"cannot_repair":false,"new_slugs":[{"type":"concept","slug":"concept/alpha","name":"Alpha","aliases":[],"description":"Alpha conditions","details":"","source_chunks":["c000","c001"],"evidence_quotes":[{"chunk":"c000","quote":"Alpha requires condition X."},{"chunk":"c001","quote":"Alpha excludes condition Y."}]}]}` got, err := applyWikiCitationDeclarations(raw, original, missing, batch, nil) require.NoError(t, err) require.Len(t, got.NewSlugs, 1) require.Empty(t, got.NewSlugs[0].Details) require.Equal(t, original.Citations, got.Citations) require.ElementsMatch(t, []string{"first", "second"}, got.NewSlugs[0].SourceChunks) for name, invalid := range map[string]string{ "missing restriction source": strings.Replace(raw, `"source_chunks":["c000","c001"]`, `"source_chunks":["c000"]`, 1), "invented restriction quote": strings.Replace(raw, `"quote":"Alpha excludes condition Y."`, `"quote":"Alpha permits condition Y."`, 1), "missing identity": strings.Replace(raw, `"name":"Alpha"`, `"name":""`, 1), } { t.Run(name, func(t *testing.T) { _, err := applyWikiCitationDeclarations(invalid, original, missing, batch, nil) require.Error(t, err) }) } require.Empty(t, original.NewSlugs) }