admin/Hermes-ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: comment out pending session delete operations in group chat (#703)

Browse Source 
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
ekko
2026-05-14 10:34:10 +08:00
committed by GitHub
parent 47ff859c7c
commit b2a80808e3
2 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/server/src/controllers/hermes/profiles.ts
+8 -7
View File
@@ -235,18 +235,19 @@ export async function switchProfile(ctx: any) {
logger.error(err, 'Ensure config failed') logger.error(err, 'Ensure config failed')
} }
const drainResult = await SessionDeleter.getInstance().drain(name) // TODO: re-enable pending session delete drain after confirming safety
// const drainResult = await SessionDeleter.getInstance().drain(name)
SessionDeleter.getInstance().switchProfile(name) SessionDeleter.getInstance().switchProfile(name)
logger.info('[switchProfile] drain result for profile "%s": %d deleted, %d failed', name, drainResult.deleted.length, drainResult.failed.length) logger.info('[switchProfile] switched session deleter to profile "%s"', name)
if (drainResult.failed.length > 0) { // if (drainResult.failed.length > 0) {
logger.warn({ profile: name, failed: drainResult.failed }, 'Failed to drain some pending session deletes after profile switch') // logger.warn({ profile: name, failed: drainResult.failed }, 'Failed to drain some pending session deletes after profile switch')
} // }
ctx.body = { ctx.body = {
success: true, success: true,
message: output.trim(), message: output.trim(),
drained_session_deletes: drainResult.deleted.length, // drained_session_deletes: drainResult.deleted.length,
failed_session_deletes: drainResult.failed.length, // failed_session_deletes: drainResult.failed.length,
} }
} catch (err: any) { } catch (err: any) {
ctx.status = 500 ctx.status = 500
packages/server/src/services/hermes/group-chat/index.ts
+9 -7
View File
@@ -448,13 +448,15 @@ export class GroupChatServer {
const contextEngine = new ContextEngine({ const contextEngine = new ContextEngine({
messageFetcher: this.storage, messageFetcher: this.storage,
sessionCleaner: async (sessionId: string) => { sessionCleaner: async (sessionId: string) => {
try { // TODO: re-enable session deletion after confirming it doesn't
const profile = this.storage.getSessionProfile(sessionId) // accidentally remove user-created sessions outside group chat.
const profileName = profile?.profile_name || 'default' // try {
this.storage.enqueuePendingSessionDelete(sessionId, profileName) // const profile = this.storage.getSessionProfile(sessionId)
} catch (err: any) { // const profileName = profile?.profile_name || 'default'
logger.warn(`[GroupChat] failed to enqueue compression session delete ${sessionId}: ${err.message}`) // this.storage.enqueuePendingSessionDelete(sessionId, profileName)
} // } catch (err: any) {
// logger.warn(`[GroupChat] failed to enqueue compression session delete ${sessionId}: ${err.message}`)
// }
}, },
}) })
this.agentClients.setContextEngine(contextEngine) this.agentClients.setContextEngine(contextEngine)